build: fix service with profile missing secrets #13023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
build_secret_provile
branch
from
6fea71b to
6f55b14
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13023 +/- ##
==========================================
+ Coverage 53.37% 53.64% +0.27%
==========================================
Files 160 165 +5
Lines 16642 17073 +431
==========================================
+ Hits 8882 9159 +277
- Misses 6848 6976 +128
- Partials 912 938 +26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Jul 9, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [docker/compose](https://github.com/docker/compose) | patch | `v2.38.1` -> `v2.38.2` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>docker/compose (docker/compose)</summary> ### [`v2.38.2`](https://github.com/docker/compose/releases/tag/v2.38.2) [Compare Source](docker/compose@v2.38.1...v2.38.2) #### What's Changed ##### ✨ Improvements - Add `--networks` flag to config command by [@​jarqvi](https://github.com/jarqvi) in docker/compose#13021 ##### 🐛 Fixes - Add a Done event to model progress display by [@​glours](https://github.com/glours) in docker/compose#13008 - Fix the way we're checking if the provider metadata are empty or not by [@​glours](https://github.com/glours) in docker/compose#13017 - Build: fix service with profile missing secrets by [@​ndeloof](https://github.com/ndeloof) in docker/compose#13023 - Fix select dockerignore based on Dockerfile name set from symlink by [@​ndeloof](https://github.com/ndeloof) in docker/compose#13024 ##### 🔧 Internal - pkg/compose: remove redundant uses of strslice.StrSlice by [@​thaJeztah](https://github.com/thaJeztah) in docker/compose#13002 - (reactoring) avoid a global variable by introducing logConsumer decorator by [@​ndeloof](https://github.com/ndeloof) in docker/compose#12945 - Chore: fix some minor issues in the comments by [@​mountdisk](https://github.com/mountdisk) in docker/compose#12991 - A single place for shell-out command setup by [@​ndeloof](https://github.com/ndeloof) in docker/compose#13007 - Add USER\_AGENT variable to cmd when shellouting by [@​glours](https://github.com/glours) in docker/compose#13025 ##### ⚙️ Dependencies - Bump golang to v1.23.10 by [@​glours](https://github.com/glours) in docker/compose#13004 - Bump go-viper/mapstructure to version v2.3.0 by [@​glours](https://github.com/glours) in docker/compose#13005 - Build(deps): bump github.com/moby/buildkit from 0.23.1 to 0.23.2 by [@​dependabot](https://github.com/dependabot) in docker/compose#13009 - Build(deps): bump github.com/docker/cli from 28.3.0+incompatible to 28.3.1+incompatible by [@​dependabot](https://github.com/dependabot) in docker/compose#13012 - Build(deps): bump github.com/docker/docker from 28.3.0+incompatible to 28.3.1+incompatible by [@​dependabot](https://github.com/dependabot) in docker/compose#13011 #### New Contributors - [@​mountdisk](https://github.com/mountdisk) made their first contribution in docker/compose#12991 **Full Changelog**: docker/compose@v2.38.1...v2.38.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MC42Mi4xIiwidXBkYXRlZEluVmVyIjoiNDAuNjIuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
As build resolves enabled service after project has been loaded, we must not drop "unused resources" as we actually don't know they are.
Related issue
fixes #13020
(not mandatory) A picture of a cute animal, if possible in relation to what you did