removed indent width for custom list level settings#70
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the indentionWidth field from ProtoCustomListLevelSetting across the source proto and generated artifacts, and bumps the npm package version.
Changes:
- Dropped
indentionWidthfromProtoCustomListLevelSetting. - Renumbered
doctypeCodefrom field5to4and updated generated outputs (Go/JS/TS/C#) accordingly. - Bumped
package.jsonversion from0.8.5to0.8.6.
Reviewed changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/DocumentElements/documentelements.list_level_setting.proto | Removes indentionWidth and renumbers doctypeCode in ProtoCustomListLevelSetting. |
| build/docframe.proto | Mirrors the same field removal/renumbering in the bundled proto. |
| docframepb/docframe.pb.go | Updates generated Go struct/accessors and descriptor encoding for the changed proto field numbers. |
| build/Docframe.js | Updates generated JS encode/decode/verify logic for the changed fields. |
| build/Docframe.d.ts | Removes indentionWidth from generated TS typings. |
| build/Docframe.cs | Updates generated C# message metadata/serialization for the changed field numbers. |
| package.json | Version bump to 0.8.6. |
Files not reviewed (1)
- docframepb/docframe.pb.go: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
129
to
+133
| string listSettingName = 1; | ||
| ProtoListLevelSettingType type = 2; | ||
| int32 level = 3; | ||
| int32 indentionWidth = 4; | ||
|
|
||
| string doctypeCode = 5; | ||
| string doctypeCode = 4; |
Comment on lines
500
to
+504
| string listSettingName = 1; | ||
| ProtoListLevelSettingType type = 2; | ||
| int32 level = 3; | ||
| int32 indentionWidth = 4; | ||
|
|
||
| string doctypeCode = 5; | ||
| string doctypeCode = 4; |
lukasbash
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.