Skip to content

feat: Added TableCellSpacing #3052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 16, 2025

Conversation

CodingTimeDEV
Copy link
Contributor

Hi all,

this PR adds the possibility to add cell spacing to tables.

According to docs the spacing can be added to a table itself or a row, both versions are implemented here.
(http://officeopenxml.com/WPtableCellSpacing.php).

Link to the docs has also been added to the files.

Checked with eslint => No conflicts
Ran vitest => All tests passed successfully
Ran build => build was successfull

I also went ahead and copied the dist folder into a different project to validate that the cell spacing is in fact applied (Visuals only checked in word).

If you have any further questions or I missed a step in your contributions guide, please give me a heads up and I'll resolve this.

Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (409ea02) to head (8d4c417).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #3052   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          290       291    +1     
  Lines         8796      8823   +27     
  Branches      1423      1426    +3     
=========================================
+ Hits          8796      8823   +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dolanmiu dolanmiu merged commit 44d4b93 into dolanmiu:master Apr 16, 2025
8 checks passed
@dolanmiu
Copy link
Owner

Looks great! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants