Fix parameter tests with localized values #10959
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
added
the
area-app-model
There was a problem hiding this comment.
Pull Request Overview
This PR fixes test failures that occurred when hardcoded English strings in parameter tests didn't match localized values being used by the parameter service. The fix replaces hardcoded placeholder text with calls to the localized string resource.
- Updates parameter tests to use localized string resources instead of hardcoded English text
- Adds import for
Aspire.Hosting.Resourcesnamespace to access localization resources
|
If there are still problems then we'll hardcode this test culture as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameter service uses localized values which causes some hardcoded tests to fail.
Fixes failing localization update: https://github.com/dotnet/aspire/actions/runs/16953709172?pr=10944