rafs: fix a underflow bug in rafs v6 implementation #1017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a underflow bug in find_target_block() of RAFS v6. `last` is usize instead of isize so it may underflow. Signed-off-by: Jiang Liu <[email protected]>
|
@jiangliu , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/44589 |
hsiangkao
reviewed
Jan 18, 2023
| let inode = self.disk_inode(); | ||
| if inode.size() == 0 { | ||
| return Err(enoent!()); |
There was a problem hiding this comment.
There are several map_err()? in the function body.
There was a problem hiding this comment.
And the caller get_child_by_name() while return enoent() if find_target_block() returns Ok(None).
|
@jiangliu , The CI test is completed, please check result:
Sorry, your test job failed. Please get the details in the link. |
||||||||||||||||||||||||
hsiangkao
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a underflow bug in find_target_block() of RAFS v6.
lastis usize instead of isize so it may underflow.Signed-off-by: Jiang Liu [email protected]