nydus-test: don't fetch iostats per file metrics #1031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The files' metrics have a large size ending up with uncompleted json string. The root cause why the buffer is so uncomleted is still in fog. Moreover, we are going to remove files's metrics in the future. Signed-off-by: Changwei Ge <[email protected]>
changweige
requested review from
bergwolf,
jiangliu and
hhhhsdxxxx
and removed request for
a team
|
@changweige , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/45606 |
|
@changweige , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
|
Aha, the dbs-uhttps has a limitation of message size, is it caused by that? |
It's possible, however, due to de fact that metrics of all files' iostats might be removed in the future. Shall we just remove the test observations points? |
jiangliu
approved these changes
Jan 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The files' metrics have a large size ending up with uncompleted json string. The root cause why the buffer is so uncomleted is still in fog. Moreover, we are going to remove files's metrics in the future.
Signed-off-by: Changwei Ge [email protected]