build: clean up libz-sys stale cache for static build #1032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiangliu
requested review from
imeoer,
luodw and
changweige
and removed request for
a team
changweige
reviewed
Jan 29, 2023
Makefile
Outdated
| @@ -84,6 +84,10 @@ endef | |||
| .musl_target: | |||
| $(eval CARGO_BUILD_FLAGS += --target ${RUST_TARGET_STATIC}) | |||
|
|
|||
| .clean_libz_sys: | |||
| ${CARGO} clean --target ${RUST_TARGET_STATIC} -p libz-sys | |||
| ${CARGO} clean --target ${RUST_TARGET_STATIC} --release -p libz-sys | |||
There was a problem hiding this comment.
Should we prefix the instrunction with @ to hide the command print and make it clear
The docker and host build env use different root path, which causes libz-sys to report inconsistent cache state. Fixes: dragonflyoss#1028 Signed-off-by: Jiang Liu <[email protected]>
|
@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/45611 |
|
@jiangliu , The CI test is completed, please check result:
Congratulations, your test job passed! |
||||||||||||||||||||||||
changweige
approved these changes
Jan 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker and host build env use different root path, which causes libz-sys to report inconsistent cache state.
Fixes: #1028
Signed-off-by: Jiang Liu [email protected]