Skip to content

Fix anolis test #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2023
Merged

Fix anolis test #1052

merged 2 commits into from
Feb 3, 2023

Conversation

changweige
Copy link
Contributor

Update smoke tests on anolis and docs about how to start nydus-snapshotter service.
In addition, simplify how to start nydus-snapshotter by removing cli flags with the same value as default value

@changweige changweige requested a review from a team as a code owner February 3, 2023 07:04
@changweige changweige requested review from liubogithub, imeoer and adamqqqplay and removed request for a team February 3, 2023 07:04
@anolis-bot
Copy link
Collaborator

@changweige , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/47762

@@ -89,13 +89,10 @@ make
mkdir -p /var/lib/containerd-nydus

./bin/containerd-nydus-grpc \
--config-path /etc/nydus/nydusd-config.fscache.json \
--nydusd-config /etc/nydus/nydusd-config.fscache.json \
--daemon-mode shared \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, we can also remove the flag as --fs-driver fscache enforces it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

others LGTM!

@anolis-bot
Copy link
Collaborator

@changweige , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/47776

@anolis-bot
Copy link
Collaborator

@changweige , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch✅ SUCCESS
build-docker-image✅ SUCCESS
compile-nydus✅ SUCCESS
compile-ctr-remote✅ SUCCESS
compile-nydus-snapshotter✅ SUCCESS
start-nydus-snapshotter-config-containerd✅ SUCCESS
run-container-with-nydus-image❌ FAIL

Sorry, your test job failed. Please get the details in the link.

@anolis-bot
Copy link
Collaborator

@changweige , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch✅ SUCCESS
build-docker-image✅ SUCCESS
compile-nydus✅ SUCCESS
compile-ctr-remote✅ SUCCESS
compile-nydus-snapshotter✅ SUCCESS
start-nydus-snapshotter-config-containerd✅ SUCCESS
run-container-with-nydus-image❌ FAIL

Sorry, your test job failed. Please get the details in the link.

@imeoer imeoer merged commit 005c3b7 into dragonflyoss:master Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants