nydusify: refactor check subcommand #1652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imeoer
requested review from
hsiangkao,
power-more and
Desiki-high
and removed request for
a team
imeoer
force-pushed
the
nydusify-checker-enhance
branch
from
7918b55 to
efe63c3
Compare
imeoer
changed the title
imeoer
changed the title
imeoer
force-pushed
the
nydusify-checker-enhance
branch
2 times, most recently
from
62a9ca5 to
a09f536
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1652 +/- ##
==========================================
- Coverage 60.05% 59.86% -0.19%
==========================================
Files 147 147
Lines 49624 49749 +125
Branches 47078 47078
==========================================
- Hits 29802 29784 -18
- Misses 18040 18177 +137
- Partials 1782 1788 +6
|
imeoer
force-pushed
the
nydusify-checker-enhance
branch
from
a09f536 to
d294237
Compare
imeoer
force-pushed
the
nydusify-checker-enhance
branch
from
d294237 to
573922d
Compare
- allow either the source or target to be an OCI or nydus image; - improve output directory structure and log format; Signed-off-by: Yan Song <[email protected]>
imeoer
force-pushed
the
nydusify-checker-enhance
branch
from
573922d to
322d9a3
Compare
|
Let's fix the broken nextest CI after merging the PR, it's unrelated to this PR's changes. |
imeoer
added a commit
to imeoer/image-service
that referenced
this pull request
Mar 25, 2025
The output bootstrap path has been changed in the nydusify check subcommand. Related PR: dragonflyoss#1652 Signed-off-by: Yan Song <[email protected]>
BraveY
pushed a commit
that referenced
this pull request
Mar 25, 2025
The output bootstrap path has been changed in the nydusify check subcommand. Related PR: #1652 Signed-off-by: Yan Song <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue (if applicable)
If there are Issues related to this PullRequest, please list it.
Details
Please describe the details of PullRequest.
Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.