Skip to content

chore(smoke): fix smoke test failed #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025
Merged

Conversation

BraveY
Copy link

@BraveY BraveY commented Mar 24, 2025

This pull request includes several changes to the .github/workflows/smoke.yml file and some commented-out code in the service/src/singleton.rs file. The changes aim to fix failed smoke test.

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

Please describe the details of PullRequest.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@BraveY BraveY requested review from a team as code owners March 24, 2025 04:33
@BraveY BraveY requested review from bergwolf, liubin, hsiangkao and imeoer and removed request for a team March 24, 2025 04:33
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.27%. Comparing base (7e51479) to head (ce5517c).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1676      +/-   ##
==========================================
- Coverage   60.42%   60.27%   -0.15%     
==========================================
  Files         146      146              
  Lines       48943    49086     +143     
  Branches    46380    46398      +18     
==========================================
+ Hits        29573    29589      +16     
- Misses      17906    18027     +121     
- Partials     1464     1470       +6     

see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@imeoer
Copy link
Collaborator

imeoer commented Mar 25, 2025

Let's figure out why make failed.

@BraveY
Copy link
Author

BraveY commented Mar 25, 2025

Let's figure out why make failed.

I think the new release of rustup v1.28's PR rust-lang/rustup#4022 where cargo-home/bin/cargo is symlinked to cargo-home/bin/rustup caused this problem. I fixed the broken CI by running ${RUSTUP} run stable cargo nextest run instead of ${CARGO} nextest run. Using rustup run to explicitly specify the toolchain is a workaround.

Run `rustup run stable cargo` instead of `cargo` to explicitly specify the toolchain.

Since `nextest` fails due to symlink resolution with new rustup v1.28.

Signed-off-by: Yang Kaiyong <[email protected]>
@imeoer imeoer merged commit 871e1c6 into dragonflyoss:master Mar 25, 2025
24 checks passed
@BraveY BraveY deleted the fix-smoke branch April 16, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants