Skip to content

builder: remove redundant blobs for merge subcommand #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2025

Conversation

imeoer
Copy link
Collaborator

@imeoer imeoer commented Mar 24, 2025

After merging all trees, we need to re-calculate the blob index of referenced blobs, as the upper tree might have deleted some files or directories by opaques, and some blobs are dereferenced.

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

Please describe the details of PullRequest.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

After merging all trees, we need to re-calculate the blob index of
referenced blobs, as the upper tree might have deleted some files
or directories by opaques, and some blobs are dereferenced.

Signed-off-by: Yan Song <[email protected]>
@imeoer imeoer requested a review from a team as a code owner March 24, 2025 09:13
@imeoer imeoer requested review from bergwolf, jiangliu and Desiki-high and removed request for a team March 24, 2025 09:13
To check the compatibility between the newer builder and old nydusd.

Signed-off-by: Yan Song <[email protected]>
@imeoer imeoer force-pushed the fix-redundant-blobs branch from 4f4f9e0 to f41448b Compare March 24, 2025 10:50
Copy link

@BraveY BraveY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@imeoer imeoer merged commit bd2123f into dragonflyoss:master Mar 24, 2025
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants