Skip to content

nydusify(feat): add crc32 in file attributes #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025

Conversation

BraveY
Copy link

@BraveY BraveY commented Apr 18, 2025

Read CRC32 from external models' manifest and pass it to builder.

Relevant Issue (if applicable)

If there are Issues related to this PullRequest, please list it.

Details

Please describe the details of PullRequest.

Types of changes

What types of changes does your PullRequest introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@BraveY BraveY requested a review from a team as a code owner April 18, 2025 06:47
@BraveY BraveY requested review from gaius-qi, changweige and Desiki-high and removed request for a team April 18, 2025 06:47
Copy link

codecov bot commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.35%. Comparing base (96c3e55) to head (e8856d5).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1683      +/-   ##
==========================================
+ Coverage   55.34%   55.35%   +0.01%     
==========================================
  Files         197      197              
  Lines       55706    55720      +14     
  Branches    47176    47176              
==========================================
+ Hits        30828    30845      +17     
+ Misses      23277    23275       -2     
+ Partials     1601     1600       -1     
Files with missing lines Coverage Δ
contrib/nydusify/pkg/converter/converter.go 66.16% <100.00%> (+0.08%) ⬆️
contrib/nydusify/pkg/external/modctl/remote.go 64.58% <100.00%> (+5.80%) ⬆️
...dusify/pkg/snapshotter/external/backend/backend.go 100.00% <ø> (ø)
...trib/nydusify/pkg/snapshotter/external/external.go 53.60% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM, thanks!

Read CRC32 from external models' manifest and pass it to builder.

Signed-off-by: Yang Kaiyong <[email protected]>
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@imeoer imeoer merged commit 9b91552 into dragonflyoss:master Apr 18, 2025
66 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants