Skip to content

nydusd: fix is_mount failure #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

liubogithub
Copy link
Collaborator

is_mount can only take a canonicalized path which is shown in
/proc/self/mounts.

Signed-off-by: Liu Bo [email protected]

Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bergwolf
Copy link
Member

smoke failed

error[E0308]: mismatched types
   --> src/bin/nydusd/fusedev.rs:405:36
    |
405 |     let session = FuseSession::new(mnt, "rafs", "", readonly)?;
    |                                    ^^^
    |                                    |
    |                                    expected `&std::path::Path`, found struct `std::path::PathBuf`
    |                                    help: consider borrowing here: `&mnt`

`is_mount` can only take a canonicalized path which is shown in
/proc/self/mounts.

Signed-off-by: Liu Bo <[email protected]>
@bergwolf bergwolf merged commit 9837b10 into dragonflyoss:master Mar 18, 2022
@liubogithub liubogithub deleted the liubo/dev/path branch June 27, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants