action: support multiple arch releases #407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imeoer
force-pushed
the
nydus-arm64-release
branch
2 times, most recently
from
05a604e to
5276987
Compare
liubogithub
reviewed
Apr 27, 2022
Makefile
Outdated
| current_dir := $(shell dirname $(realpath $(firstword $(MAKEFILE_LIST)))) | ||
| ARCH := $(shell uname -p) | ||
| ARCH ?= $(shell uname -p) | ||
| GOARCH ?= amd64 |
There was a problem hiding this comment.
Is this GOARCH used anywhere?
There was a problem hiding this comment.
Thanks for pointing it out, fixed.
Add $ARCH to all cargo/go build commands for supporting multiple arch compilation. Use rust cross tool instead of clux/muslrust docker image to resolve cross compiling issue for arm64 arch. All the amd64 and arm64 binaries have been tested on separate machines and basically work well. Signed-off-by: Yan Song <[email protected]>
imeoer
force-pushed
the
nydus-arm64-release
branch
from
5276987 to
aedb0f5
Compare
bergwolf
reviewed
Apr 27, 2022
bergwolf
reviewed
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add $ARCH to all cargo/go build commands for supporting multiple
arch compilation.
Use rust cross tool instead of clux/muslrust docker image to
resolve cross compiling issue for arm64 arch.
All the amd64 and arm64 binaries have been tested on separate
machines and basically work well.
A successful action can be found here: https://github.com/imeoer/image-service/actions/runs/2230520032
The macOS binary release support and removing clux/muslrust docker
image will as TODO next.
Close #401
Signed-off-by: Yan Song [email protected]