Tiny typo fix and improve nydusd help message #461
Merged
+15
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also it fixes a tiny spelling mistake. Signed-off-by: Changwei Ge <[email protected]>
hsiangkao
reviewed
May 31, 2022
src/bin/nydusd/main.rs
Outdated
| @@ -210,7 +210,7 @@ fn append_fs_options(app: App<'static, 'static>) -> App<'static, 'static> { | |||
| Arg::with_name("shared-dir") | |||
| .long("shared-dir") | |||
| .short("s") | |||
| .help("Directory shared by host and guest for passthroughfs, which also enables pathroughfs mode") | |||
| .help("Directory shared by host and guest for passthroughfs or a passthroughfs source for FUSE(for test and demonstration purpose), which also enables passthroughfs mode") | |||
There was a problem hiding this comment.
should we a space and (for the purpose of testing and demonstration)
There was a problem hiding this comment.
Sure, leaving a white space makes it neater.
There was a problem hiding this comment.
Then the help message looks like below:
imeoer
reviewed
May 31, 2022
It should be ServiceController rather than ServiceContoller Signed-off-by: Changwei Ge <[email protected]>
jiangliu
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frankly speaking,
--shared-diris useless when nydusd works on FUSE mode. But we can still use this option to demonstrate that nydusd can work as FUSE passthroughfs and test the corresponding logics belong tofuse-backend-rs.Add a more detailed help message telling why it is reserved.
In addition, fix a type name.