Skip to content

FIX: miss blob header in inline-nydus-file #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2022

Conversation

ccx1024cc
Copy link
Contributor

DESCRIPTION

Inline-nydus-file consists of blob data, blob header, bootstrap data, bootstrap header. However the part of blob header is missed now.

REPRODUCTION

# Source Directory
export source=${SOURCE_DIR}
# Output File
export output=${OUTPUT}

sudo nydus-image create --log-level info  --blob ${output}--source-type directory --whiteout-spec none --fs-version 5 --inline-bootstrap ${source}

# There is no blob header
sudo hexdump -C ${output}

EXPECT

Inline File consist of blob data, blob header, bootstrap data, bootstrap header in order.

FIX

  1. Fix a condition.
  2. Add smoke for inline file in V5 & V6

@yqleng1987
Copy link
Contributor

@ccx1024cc , a new test job has been submitted. Please wait in patience.

@yqleng1987
Copy link
Contributor

@ccx1024cc , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch❌FAIL

Sorry, your test job failed. Please get the details in the link.

@ccx1024cc ccx1024cc force-pushed the morgan/fix_miss_blob_header branch from bd8578f to 74f41bb Compare June 25, 2022 02:24
@yqleng1987
Copy link
Contributor

@ccx1024cc , your pull request has been updated. A new test job will be submitted. Please wait in patience.

@yqleng1987
Copy link
Contributor

@ccx1024cc , the test job has been submitted. Please wait in patience.

@yqleng1987
Copy link
Contributor

@ccx1024cc , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch❌FAIL

Sorry, your test job failed. Please get the details in the link.

@ccx1024cc ccx1024cc requested review from imeoer and bergwolf June 25, 2022 02:45
@yqleng1987
Copy link
Contributor

/retest

@yqleng1987
Copy link
Contributor

@yqleng1987 , the test job has been submitted. Please wait in patience.

@yqleng1987
Copy link
Contributor

@yqleng1987 , The CI test is completed, please check result:

Test CaseTest Result
merge-target-branch✅SUCCESS
build-docker-image✅SUCCESS
compile-nydus✅SUCCESS
compile-ctr-remote✅SUCCESS
compile-nydus-snapshotter✅SUCCESS
start-nydus-snapshotter-config-containerd✅SUCCESS
run-container-with-nydus-image✅SUCCESS

Congratulations, your test job passed!

@jiangliu jiangliu merged commit becca84 into dragonflyoss:master Jun 25, 2022
@ccx1024cc ccx1024cc deleted the morgan/fix_miss_blob_header branch October 9, 2022 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants