nydusd: rename daemon subcommand to singleton #722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that it is clear that the subcommand means to run nydusd in a global single instance mode. Signed-off-by: Peng Tao <[email protected]>
|
@bergwolf , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/21473 |
|
@bergwolf , The CI test is completed, please check result:
Sorry, your test job failed. Please get the details in the link. |
||||||||||||||||||||||||
imeoer
reviewed
Sep 16, 2022
| @@ -324,8 +324,8 @@ fn append_virtiofs_subcmd_options(app: App<'static, 'static>) -> App<'static, 's | |||
| } | |||
|
|
|||
| fn append_services_subcmd_options(app: App<'static, 'static>) -> App<'static, 'static> { | |||
| let subcmd = SubCommand::with_name("daemon") | |||
| .about("Run as a global daemon hosting multiple blobcache/fscache/virtiofs services.") | |||
| let subcmd = SubCommand::with_name("singleton") | |||
There was a problem hiding this comment.
Maybe should update together with snapshotter: https://github.com/containerd/nydus-snapshotter/blob/0f88fb6a4f190c01bab42aba2bd47aca784546c2/pkg/process/manager.go#L318
There was a problem hiding this comment.
nydus-snapshotter is shipping with the latest nydus releases. We should update it when tagging a new nydusd release.
I've raised a PR there to prepare for it: containerd/nydus-snapshotter#175
imeoer
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that it is clear that the subcommand means to run nydusd in a global single instance mode.