Fix install.sh script

[ali-essam]

When installing I was getting Failed to connect to bus: No such file or directory from systemctl. I changed it to a system service and it's working fine now. Also moved sudo permissions from /etc/sudoers to /etc/sudoers.d/subwoofer as per sudoers suggestion. Now it's working fine on my side (on a fresh Ubuntu 16.04 installation)

[dragosprju]

I would make it a prompt but I have my diploma project due soon. Hobby coding time is absolutely zero for me.

I'm not sure what being a 'system' service would imply? I would make it a prompt/choice with messages such as 'do it on your own risk' and 'in case the user service method doesn't work' for users to choose to install it as a 'system' service or a 'user' service. I'm just thinking if there's a hacker and he/she wants to exploit my Lenovo Y50 laptop, I don't want a random /opt/subwoofer.py script to be my Achile's heel if somehow permissions are bad AND it's a 'system' service (which I don't know what it entails).

Also there's an exit 0 in the middle of install.sh?

Thank you for taking an interest (with a pull request even!) and I'm really glad the script helped! 👍

[ali-essam]

"systemd offers users the ability to manage services under the user's control with a per-user systemd instance, enabling users to start, stop, enable, and disable their own units. This is convenient for daemons and other services that are commonly run for a single user, such as mpd, or to perform automated tasks like fetching mail. With some caveats it is even possible to run xorg and the entire window manager from user services." - https://wiki.archlinux.org/index.php/Systemd/User

I'm not a security expert, but I don't think there is much difference here as per the definition. AFAIK the main difference is that system is run for all users. But suoders only include your user so I guess it should be ok.

Regarding that exit 0, I was debugging something and forgot to remove it before committing 😅

And actually thank you for publishing this in the first place, and good luck with your diploma project 😄

[dragosprju]

Yeah, makes perfect sense. Couldn't even Google - I'm scared of researching more stuff than I am right now.

Merged! Thanks for taking care of the script!