Fixed rotation and matrix values for quicktime. #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 8, 2019 16:27
…ckwise. Fixed reading matrix values.
|
No idea how to resolve the CodeFactor issue. |
drewnoakes
reviewed
Jan 8, 2019
MetadataExtractor/Formats/QuickTime/QuickTimeReaderExtensions.cs
Outdated
Show resolved
Hide resolved
Added link to matrix reference. Removed unused function.
|
I'm not sure about the Java implementation. I've adjusted the .NET rotation calculation, so the values are what to expect and also orientated on the exit-tool implementation. |
|
@deonberlin thanks very much for the update here. Looks great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rotation values are now all positive ranging from 0 to 360 degree clockwise.
Fixed reading matrix values.