Add crude CR3 support #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
P.S. FileType.Crx added in separate branch. |
|
Sorry about the mess. |
|
@dmitry-shechtman this looks really great, thanks! Do you have a CRX file you could provide to the image library for benchmarking and regression testing? |
drewnoakes
approved these changes
Sep 8, 2019
|
@drewnoakes Thanks. I used images and movie from the format description. To clarify, "crx" is the format (taken from the "major brand" string); the file types are CR3 and CRM. |
|
Thanks for the clarification. I haven't looked at this format before, and only briefly reviewed https://github.com/lclevy/canon_cr3 before merging this PR. The changes on your |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my stab at a minimal CR3 support.
CR3 is based on ISO/IEC 14496-12,
which means it is detected as QuickTime. The moov container wraps 4 TIFF IFDs (and other data, which will be ignored).Edit: Added CRX file type; see below.
Edit 2: Fixed CMT2 directory type.