Skip to content

Add TGA support #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 1, 2019
Merged

Add TGA support #233

merged 7 commits into from
Dec 1, 2019

Conversation

dmitry-shechtman
Copy link
Contributor

No description provided.

Copy link
Owner

@drewnoakes drewnoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Looks good! Some comments below. I should set up an analyzer for some of these style things to make reviews easier.

I always thought of these files as "Targa" files. Is "TGA" a more common name, or just the file extension? In general I've tried to use the friendly name in type names, directory Name values, etc.

@dmitry-shechtman
Copy link
Contributor Author

I always thought of these files as "Targa" files. Is "TGA" a more common name, or just the file extension? In general I've tried to use the friendly name in type names, directory Name values, etc.

It is commonly known as TARGA, but that's the name of the video card it was used for. I stuck to the official name.

@drewnoakes
Copy link
Owner

Do you have some sample .tga files you can provide for the sample library to help prevent regressions here?

@dmitry-shechtman
Copy link
Contributor Author

dmitry-shechtman commented Nov 13, 2019

Do you have some sample .tga files you can provide for the sample library to help prevent regressions here?

Some of the TGAs I tested on are from ezQuake:

https://github.com/ezQuake/ezquake-media/tree/master/game/textures

Specific files that might be useful:

  • models/simple_backpack_0.tga - top to bottom, 0 attribute bits per pixel
  • shellmap.tga - uncompressed true color

Both have footers, but no extension/developer areas.

@drewnoakes drewnoakes merged commit 4b2ac48 into drewnoakes:master Dec 1, 2019
@drewnoakes
Copy link
Owner

Thanks! I fixed the merge conflicts and made a few other tweaks, verifying the output matches for the ezQuake sample images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants