Skip to content

Add support for Reconyx type 3 tags #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 24, 2019
Merged

Add support for Reconyx type 3 tags #242

merged 2 commits into from
Dec 24, 2019

Conversation

patricksadowski
Copy link
Contributor

Fixes #202

@patricksadowski patricksadowski changed the title WIP: Add support for Reconyx type 3 tags Add support for Reconyx type 3 tags Dec 18, 2019
@patricksadowski patricksadowski marked this pull request as ready for review December 18, 2019 14:55
drewnoakes
drewnoakes reviewed Dec 23, 2019
View reviewed changes
Copy link
Owner

@drewnoakes drewnoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great, thanks! One fix (bounds check) and a proposal to add a unit to the other field name. I know it differs from what's at https://exiftool.org/TagNames/Reconyx.html but I think it makes the distinction clearer.

@drewnoakes drewnoakes merged commit 7bbf217 into drewnoakes:master Dec 24, 2019
@drewnoakes
Copy link
Owner

Thanks very much!

@patricksadowski patricksadowski deleted the reconyx-type3-tags branch December 26, 2019 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewnoakes drewnoakes drewnoakes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reconyx HF2 PRO COVERT maker notes not supported (Type 3)
2 participants
@patricksadowski @drewnoakes