Skip to content

Use invariant culture for regression tests #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

patricksadowski
Copy link
Contributor

Closes #89

With this change I've got two changes in the test image repo:

jpg/metadata/dotnet/Reconyx HF2 Pro Covert.jpg.txt
@@ -37,7 +37,7 @@ TYPE: JPEG
-[Reconyx HyperFire 2 Makernote - 0x0030] Firmware Date = 24/08/2018
+[Reconyx HyperFire 2 Makernote - 0x0030] Firmware Date = 08/24/2018
tif/ImageTestSuite/metadata/dotnet/efb780f70a7d94fa98adfc98d2aa8d50.tif.txt
@@ -56,7 +56,7 @@ TYPE: TIFF
-[Exif SubIFD - 0x9206] Subject Distance = ∞ metres
+[Exif SubIFD - 0x9206] Subject Distance = Infinity metres

Copy link
Owner

@drewnoakes drewnoakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

FYI I've started migrating this tooling to the metadata-extractor-images repo (here https://github.com/drewnoakes/metadata-extractor-images/tree/source/src/dotnet). That way we can have the code alongside the data it creates, both for Java and .NET, and update both languages at the same time.

@drewnoakes drewnoakes merged commit 56670e2 into drewnoakes:master Jan 1, 2020
@patricksadowski patricksadowski deleted the invariant-regression-tests branch January 2, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression tests should not use machine's locale
2 participants