- Added the xmp directory in HEIF format (iso-14496). #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kastwey
commented
Jul 16, 2020
kastwey
commented
- Added the xmp directory in HEIF format (iso-14496). Related to issue Feature Request: HEIF/HEIC/Apple support #231.
- Fixed a bug where under certain circumstances, the bytes of the exif directory were extended to the next box.
- Fixed an unknown issue when the segments to be parsed start before last position after reading all boxes. Reordered segments bassed on extended offset, not only base offset, so the read will always be in sequential order. This last change fixes the exception thrown in the image file heic/Issue 487.heic.
added 2 commits
July 5, 2020 12:53
…under certain circumstances, the bytes of the exif directory were extended to the next box.
…st position after reading all boxes. Reordered segments bassed on extended offset, not only base offset, so the read will always be in sequential order. This last change fixes the exception thrown in the image file heic/Issue 487.heic.
|
@kastwey thanks very much for your contributions. Are you able to provide sample files that repro these problems? |
|
Hi! Yes, here it is: |
drewnoakes
approved these changes
Jul 19, 2020
|
Great! Thanks! :) |
drewnoakes
added a commit
to drewnoakes/metadata-extractor-images
that referenced
this pull request
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.