Olympusrawdev #44
Merged
Olympusrawdev #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great. Before I merge it, can you remove the first two commits just to keep things clearer? You can do that via an interactive rebase. Let me know if it's something you'd like some help with. Also, I've fetched your commits to my machine as a backup, so don't worry about losing anything. |
Use DateTimeOffset instead of DateTime Revert "Use DateTimeOffset instead of DateTime" This reverts commit 0ec0dca. Olympus Raw Development subifd (0x2030) directory
|
That was... odd, but I think it's ok now. If not, let me know. |
|
Perfect. The build failed due to an error on the AppVeyor side it seems. Have triggered a new build and will merge if/when it passes. |
drewnoakes
added a commit
to drewnoakes/metadata-extractor-images
that referenced
this pull request
Apr 20, 2016
- Raw Development (drewnoakes/metadata-extractor-dotnet#44) - Raw Development 2 (drewnoakes/metadata-extractor-dotnet#45) - Image Processing (drewnoakes/metadata-extractor-dotnet#46) - Focus Info (drewnoakes/metadata-extractor-dotnet#47) Addresses "Invalid TIFF tag format code 13 for tag 0x20*0" issues. Many thanks to @kwhopper for these PRs!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements another Olympus subifd (Raw Development, 0x2030) as a directory. Cleans-up more format 13 errors from the images project.