-
Notifications
You must be signed in to change notification settings - Fork 1
sleepy processes #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
sleepy processes #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d7bfd01
to
47e620b
Compare
6cfe086
to
86983bc
Compare
karalekas
approved these changes
Mar 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall this lgtm! just add another short PR description like for other one explaining anything worth noting (e.g. use of wake-for-network)
dtqec/aether#41 (review) + rebase |
17f3001
to
4611549
Compare
4611549
to
2cc28e6
Compare
2cc28e6
to
5dbd283
Compare
CI on main: 17m 57s -> CI on this branch: 15m 8s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
companion to dtqec/aether#41 .
most of the changes are rote, dropping now from the event handler signatures and changing finish-with-scheduling to finish-handler. the only meaningful exception is where i placed wake-on-network, which is used to sleep a process until the next bit of network activity might give it something to do. this is appropriate for totally passive-input-driven loops, like a non-root node's fully blocking busy wait on network activity; but it would be inappropriate for some of the dryad retries, where it needs to actively re-query nodes to find out if they're newly ready to be offloaded (& it cannot rely on them sending it a message to spur it to action).