Skip to content

sleepy processes #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 24, 2025
Merged

sleepy processes #58

merged 12 commits into from
Mar 24, 2025

Conversation

ecpeterson
Copy link
Contributor

@ecpeterson ecpeterson commented Mar 4, 2025

companion to dtqec/aether#41 .

most of the changes are rote, dropping now from the event handler signatures and changing finish-with-scheduling to finish-handler. the only meaningful exception is where i placed wake-on-network, which is used to sleep a process until the next bit of network activity might give it something to do. this is appropriate for totally passive-input-driven loops, like a non-root node's fully blocking busy wait on network activity; but it would be inappropriate for some of the dryad retries, where it needs to actively re-query nodes to find out if they're newly ready to be offloaded (& it cannot rely on them sending it a message to spur it to action).

@ecpeterson ecpeterson changed the title sleepy proceses sleepy processes Mar 4, 2025
@ecpeterson ecpeterson requested a review from karalekas March 5, 2025 05:16
Copy link
Member

@karalekas karalekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall this lgtm! just add another short PR description like for other one explaining anything worth noting (e.g. use of wake-for-network)

@ecpeterson ecpeterson marked this pull request as ready for review March 13, 2025 03:47
@karalekas karalekas mentioned this pull request Mar 14, 2025
3 tasks
@karalekas
Copy link
Member

dtqec/aether#41 (review) + rebase

@karalekas
Copy link
Member

CI on main: 17m 57s -> CI on this branch: 15m 8s

@karalekas karalekas self-assigned this Mar 24, 2025
@karalekas karalekas merged commit d74b973 into main Mar 24, 2025
1 check passed
@karalekas karalekas deleted the feature/sleepy branch March 24, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants