Add test suite that runs anatevka on large graphs with known MWPMs #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecpeterson
approved these changes
Mar 15, 2025
| "Generates a valid Lisp symbol for a test name based on directory and file name." | ||
| (let* ((test-name (pathname-name test-path)) | ||
| (clean-name (format nil "test-blossom-suite-~A-~A" dirname test-name))) | ||
| (intern (string-upcase (substitute #\- #\/ clean-name)) :anatevka-tests)))) |
There was a problem hiding this comment.
Honestly this seems fine, since there aren't a bajillion test cases, but I have a dull memory that it's ill-advised to intern programmatically generated symbols. As an alternative, I guess we could just iterate through the directory at eval time of a single umbrella test, whether than at compile time to generate individuated tests?
Don't worry about it, just a comment.
|
Test suite is now 17m, up from 7s on main -- sounds like a job for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
tests/pydirectory containing Python code for generating random graphs and computing their MWPM w/networkx, and then saving each as a test case filedefine-blossom-suitemacro and for parsing these test case files and adding more unit tests viadefine-blossom-testTest suite is considerably slower now, but passes for all 60 additional tests.