Prewarm mod cache #1279
Merged
Prewarm mod cache #1279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The setter already called an async method without waiting for the result. Upcoming changes will add more async calls into the method, so better make it async too.
Changes that moved the mod cache from ModBridge class to Vuex caused the initial rendering of the local mod list take roughly twice as long as before (although subsequent renderings were a bit faster). Since effort has been placed recently to improve the performance, this isn't ideal. One solution to improve the performance is to start prewarming the cache as soon as a profile is selected. This obviously causes a slight performance hit when a larger profile is selected, but overall this is likely less noticeable to the user. Once the cache is warmed, there's no point in resetting the mod list when moving to Manager screen and reloading it there. These changes will make moving to the Manager screen actually faster than it was before (after the cache warming is done), and as a bonus the waiting happens on profile screen, meaning the "no mods here" disclaimer does not flash on screen while the mod list is loaded.
This doesn't affect performance as much as doing the same on the profile selection screen, but is nice for consistency.
anttimaki
force-pushed
the
move-vuex-items
branch
from
2d3bfb6 to
0d229f3
Compare
anttimaki
force-pushed
the
prewarm-mod-cache
branch
from
685a462 to
243b3f9
Compare
MythicManiac
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.