Skip to content

Fixed number parsing for --port. #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Windows81
Copy link

@Windows81 Windows81 commented Aug 12, 2025

Normally, utilising oct-server -p 81 will print the message:

Open Collaboration Server listening on localhost:NaN

This pull request attempts to fix that.

Refer to https://www.npmjs.com/package/commander#custom-option-processing for this implementation.

@msujew
Copy link
Contributor

msujew commented Aug 13, 2025

Hey @Windows81, thanks a lot for the contribution!

Before we can accept your changes, please sign the Eclipse Contributor Agreement (ECA) with the same email that was used to create the commit. This is a simple CLA that simply keeps legal trouble out of the way :)

This will also automatically pass the check on your other PR over at #154.

@Windows81
Copy link
Author

I took a look at it. However, as this is my first time contributing, I need to make an account with Eclipse.

Problem is that I'm not currently able to get the CAPTCHA to validate properly.

My email address is [email protected] in case that's needed.

@msujew
Copy link
Contributor

msujew commented Aug 13, 2025

Have you signed the ECA with [email protected]? Because the commit was created with the [email protected] email address. Please either sign the ECA with this email or amend your commit to change the email address to the one that was used to sign the ECA.

@Windows81
Copy link
Author

Thanks for the clarification. I actually haven't properly signed the commit with either. Hold on.

@msujew
Copy link
Contributor

msujew commented Aug 18, 2025

@Windows81 Did you have a chance to try it again?

@Windows81
Copy link
Author

Might try again soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants