Remove flushCaches param from acquireExclusiveVMAccessForGC #18950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amicic
force-pushed
the
flushCachesForGC
branch
from
dccf5ed to
3c62465
Compare
amicic
changed the title
OMR's acquireExclusiveVMAccessForGC is about to stop calling flushCachesForGC, so it will lose a parameter that controls it. This change just removes that actual argument at the call site, what is safe to due, since that actual value is exactly what the default value is. Signed-off-by: Aleksandar Micic <[email protected]>
amicic
force-pushed
the
flushCachesForGC
branch
from
3c62465 to
3770bc0
Compare
|
@dmitripivkine this is ready for the review. OMR part (eclipse-omr/omr#7265) is close to be ready, but has to go after this anyway. |
dmitripivkine
approved these changes
Feb 14, 2024
|
Jenkins test sanity pLinux jdk11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OMR's acquireExclusiveVMAccessForGC is about to stop calling
flushCachesForGC, so it will lose a parameter that controls it.
This change just removes that actual argument at the call site,
what is safe to due, since that actual value is exactly what
the default value is.