Update JVMTI InterruptThread for virtual threads #18964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JVMTI InterruptThread needs to invoke j.l.VirtualThread.interrupt() to interrupt a virtual thread as per the RI. Related: eclipse-openj9#18810 Signed-off-by: Babneet Singh <[email protected]>
|
@tajila Can you please review this PR? |
|
jenkins test sanity,sanity.openjdk alinux jdk21,jdk22 |
tajila
approved these changes
Feb 16, 2024
keithc-ca
reviewed
Feb 16, 2024
babsingh
added a commit
to babsingh/openj9
that referenced
this pull request
Feb 16, 2024
Related: eclipse-openj9#18964 Signed-off-by: Babneet Singh <[email protected]>
cjjdespres
reviewed
Feb 16, 2024
| } | ||
| exit: | ||
| #endif /* JAVA_SPEC_VERSION >= 19 */ |
There was a problem hiding this comment.
I'm pretty sure this is causing builds for Java < 19 to fail. The #endif extends past the brace now.
There was a problem hiding this comment.
I agree. I'll create a PR to fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JVMTI InterruptThread needs to invoke j.l.VirtualThread.interrupt()
to interrupt a virtual thread as per the RI.
Related: #18810