Skip to content

Protect JITServer code with #if defined(J9VM_OPT_JITSERVER) #18986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

mpirvu
Copy link
Contributor

@mpirvu mpirvu commented Feb 20, 2024

This fixes a build break on platforms that don't have JITServer enabled by default.

@mpirvu
Copy link
Contributor Author

mpirvu commented Feb 20, 2024

jenkins compile all jdk17

@keithc-ca
Copy link
Contributor

Building with --disable-jitserver I found two other files that won't compile:

runtime/compiler/control/CompilationThread.cpp
runtime/vm/jvminit.c

@keithc-ca
Copy link
Contributor

I aborted the builds.

@mpirvu
Copy link
Contributor Author

mpirvu commented Feb 20, 2024

I aborted the builds.

ok. I am building now locally with --disable-jitserver

This fixes a build break on platforms that don't have
JITServer enabled by default.

Signed-off-by: Marius Pirvu <[email protected]>
@mpirvu
Copy link
Contributor Author

mpirvu commented Feb 20, 2024

@keithc-ca The code that I just pushed should solve the compile issue.

@mpirvu
Copy link
Contributor Author

mpirvu commented Feb 20, 2024

jenkins compile all jdk17

@keithc-ca
Copy link
Contributor

Jenkins compile amac jdk17

@keithc-ca
Copy link
Contributor

I don't think we need to wait for approval from @dsouzai.

@keithc-ca keithc-ca removed the request for review from dsouzai February 21, 2024 02:25
@keithc-ca keithc-ca merged commit da2c022 into eclipse-openj9:master Feb 21, 2024
@mpirvu mpirvu deleted the bbfix branch February 21, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants