Skip to content

Fix transformIndexOfKnownString to handle 8bit characters properly #19044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2024
Merged

Fix transformIndexOfKnownString to handle 8bit characters properly #19044

merged 1 commit into from
Mar 1, 2024

Conversation

Akira1Saitoh
Copy link
Contributor

Avoid sign extension when assigning an 8bit value to an int32_t variable.

Issue: #18974

@Akira1Saitoh Akira1Saitoh mentioned this pull request Feb 29, 2024
Closed
@knn-k knn-k added the comp:jit label Feb 29, 2024
@knn-k
Copy link
Contributor

knn-k commented Feb 29, 2024

Jenkins test sanity all jdk17

@Akira1Saitoh Akira1Saitoh marked this pull request as ready for review February 29, 2024 08:51
@Akira1Saitoh
Copy link
Contributor Author

Link to x86 personal build: https://hyc-runtimes-jenkins.swg-devops.com/view/OpenJ9%20-%20Personal/job/Pipeline-Build-Test-Personal/20963/
Link to extended.openjdk job (I made a typo in the above job): https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/38188/

@knn-k
Copy link
Contributor

knn-k commented Feb 29, 2024

The test failure on Windows is caused by Issue #18998.

knn-k
knn-k reviewed Feb 29, 2024
View reviewed changes
@knn-k
Copy link
Contributor

knn-k commented Mar 1, 2024

@hzongaro This is a fix for a blocker issue. Could you review, please?

@Akira1Saitoh Akira1Saitoh force-pushed the fixTransformIndexOfKnownString branch from 4f45a71 to 0fd0380 Compare March 1, 2024 07:29
Fix transformIndexOfKnownString to handle 8bit characters properly
11b707f 
Avoid sign extension when assigning an 8bit value to an int32_t variable.

Signed-off-by: Akira Saitoh <[email protected]>
@Akira1Saitoh Akira1Saitoh force-pushed the fixTransformIndexOfKnownString branch from 0fd0380 to 11b707f Compare March 1, 2024 07:31
@knn-k
Copy link
Contributor

knn-k commented Mar 1, 2024

Jenkins test sanity all jdk17

@hzongaro hzongaro self-assigned this Mar 1, 2024
hzongaro
hzongaro approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@hzongaro
Copy link
Member

hzongaro commented Mar 1, 2024

Failure in JDK 17 zLinux testing appears to be due to known issue #18994

Failure in JDK 17 Windows testing is due to known issue #18998

@hzongaro
Copy link
Member

hzongaro commented Mar 1, 2024

Test failures were due to known issues, unrelated to this change. The fix itself is very safe. Merging.

@hzongaro hzongaro merged commit 78db5f9 into eclipse-openj9:master Mar 1, 2024
@pshipton
Copy link
Member

pshipton commented Mar 1, 2024

Pls create a PR for the 0.44 branch.

@Akira1Saitoh Akira1Saitoh mentioned this pull request Mar 2, 2024
Merged
@Akira1Saitoh
Copy link
Contributor Author

Opened #19056 for double delivery.

@Akira1Saitoh Akira1Saitoh deleted the fixTransformIndexOfKnownString branch March 4, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knn-k knn-k knn-k left review comments

@hzongaro hzongaro hzongaro approved these changes

Assignees

@hzongaro hzongaro

Labels
comp:jit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Akira1Saitoh @knn-k @hzongaro @pshipton