(0.44) JIT must narrow byte/short/char before storing #19108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures compliance with JVM spec regarding the handling of putstatic/putfield/withfield opcodes. This involves correctly narrowing integer values when storing them into fields of smaller types such as bool, byte, char, and short. For byte and short fields, narrowing involves conversion from integer to byte/short, then back to integer. For bool and char types, which are unsigned, narrowing entails ANDing the value with a mask matching the type width. Issue: eclipse-openj9#16498 Signed-off-by: Bradley Wood <[email protected]>
hzongaro
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures compliance with JVM spec regarding the handling of putstatic/putfield/withfield opcodes. This involves correctly narrowing integer values when storing them into fields of smaller types such as bool, byte, char, and short. For byte and short fields, narrowing involves conversion from integer to byte/short, then back to integer. For bool and char types, which are unsigned, narrowing entails ANDing the value with a mask matching the type width.
Issue: #16498
Port of #18904 for 0.44