JITServer AOT cache array class support #19138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexeyKhrabrov
force-pushed
the
aotcache_object_arrays
branch
2 times, most recently
from
787ed28 to
9a27425
Compare
mpirvu
reviewed
May 2, 2024
AlexeyKhrabrov
force-pushed
the
aotcache_object_arrays
branch
3 times, most recently
from
737768b to
b19a4ea
Compare
AlexeyKhrabrov
changed the title
|
@mpirvu This PR is ready for review now. |
cjjdespres
reviewed
May 13, 2024
cjjdespres
reviewed
May 13, 2024
AlexeyKhrabrov
force-pushed
the
aotcache_object_arrays
branch
from
b19a4ea to
d545c1f
Compare
mpirvu
reviewed
May 15, 2024
|
jenkins test sanity xlinuxjit,zlinuxjit,alinux64jit jdk21 |
This commit enables AOT cache serialization and load for methods that refer to array classes in their relocation and validation records, specifically object arrays and multidimensional primitive arrays. Since such classes share the same ROMClass named "[L", we disambiguate them in the AOT cache by using the full array class signature instead of the ROMClass name. We build the ROMClass hash for an array class by combining the ROMClass hash of the "[L" object array class, the ROMClass hash of the base component class, and the number of array dimensions. Signed-off-by: Alexey Khrabrov <[email protected]>
|
The tests have passed: https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/5481/. I'll force push the remaining changes now, which are only additional comments to clarify the points raised in the review. |
AlexeyKhrabrov
force-pushed
the
aotcache_object_arrays
branch
from
d545c1f to
f31c509
Compare
|
Since tests have passed, I am merging this PR. |
|
I should have officially approved this PR. For the record, the fact that I have merged it means that I have approved it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR implements object array class support for JITServer AOT cache. Currently untested.This PR enables AOT cache serialization and load for methods that refer to array classes in their relocation and validation records, specifically object arrays and multidimensional primitive arrays. Since such classes share the same ROMClass named
[L, we disambiguate them in the AOT cache by using the full array class signature instead of the ROMClass name. We build the ROMClass hash for an array class by combining the ROMClass hash of the[Lobject array class, the ROMClass hash of the base component class, and the number of array dimensions.