(0.44) Correct memorypool usage calculating for GMP case #19168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a gcEnd condition check patch for calculating memorypool usage at the end of GC due to the increment logic age for regions happened after getHeapMemorySnapshot(), but incrementing region's age has been updated to be called before getHeapMemorySnapshot(), condition check for gcEnd is unnecessory, also the condition check would cause incorrect memory usages for eden, reserved and survivor pools in Global Marking Phase case. -cleanup the format base on the coding standard UDATA to uintptr_t "<type>*" to "<type> *" Signed-off-by: hulin <[email protected]>
pshipton
changed the title
pshipton
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a gcEnd condition check patch for calculating memorypool usage at the end of GC due to the increment logic age for regions happened after getHeapMemorySnapshot(), but incrementing region's age has been updated to be called before getHeapMemorySnapshot(), condition check for gcEnd is unnecessory, also the condition check would cause incorrect memory usages for eden, reserved and survivor pools in Global Marking Phase case.
-cleanup the format base on the coding standard
UDATA to uintptr_t
"*" to " *"
Port of #19063 to 0.44