Fix !vthreads command error with uninitialized Continuations #19343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@babsingh can you take a look please |
keithc-ca
reviewed
Apr 25, 2024
debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/VirtualThreadsCommand.java
Outdated
Show resolved
Hide resolved
fengxue-IS
force-pushed
the
18859
branch
2 times, most recently
from
fa3b2ae to
226cb45
Compare
babsingh
approved these changes
Apr 25, 2024
keithc-ca
reviewed
Apr 25, 2024
debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/VirtualThreadsCommand.java
Outdated
Show resolved
Hide resolved
keithc-ca
reviewed
Apr 25, 2024
debugtools/DDR_VM/src/com/ibm/j9ddr/vm29/tools/ddrinteractive/VirtualThreadsCommand.java
Outdated
Show resolved
Hide resolved
|
@keithc-ca can you take another look please |
keithc-ca
requested changes
May 9, 2024
Continuation objects are added to GC list on create, which may not yet be assoicated with vthread object yet at time when coredump is generated. DDR needs to correctly handle null vthread reference. Signed-off-by: Jack Lu <[email protected]>
Fixed |
|
Jenkins test sanity alinux jdk21 |
keithc-ca
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation objects are added to GC list on create, which may not
yet be assoicated with vthread object yet at time when coredump is
generated. DDR needs to correctly handle null vthread reference.
Fix: #18859
Signed-off-by: Jack Lu [email protected]