(0.45) Fixup stack references of unmounted continuation for scavenge backout #19388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to no completeScan for scavenge backout(there are no need to fixup the references for regular objects in evacurated regions), the native stack references of unmounted continuation Objects might still point to the reversedForwardedObject in survior or tenure regions, it would cause the Assertion in following global GC. - scanContinuationNativeSlots for the continuation Objects during reverseForwardedObject. - there is no need backoutContinuationObjects processing, instead, just backout continuation list in new regions. - -Xgc:fvtest=forceScavengerBackout (for testing/debug only) is triggered wrong location(should not be triggered after continuationObjects processing, there is no more new allocation needed and no possible backout in real cases), do not use -Xgc:fvtest=forceScavengerBackout option for testing until further update. - new mehtod completedObjectScanPhasesCheckpoint() for future asserting no more abort Case happened after unfinalized/phantom processing in scavenge clearable phase. igned-off-by: hulin <[email protected]>
pshipton
changed the title
pshipton
approved these changes
Apr 26, 2024
LinHu2016
added a commit
to LinHu2016/openj9
that referenced
this pull request
May 27, 2024
In eclipse-openj9#19388, we are fixing up stack references of unmounted continuation for scavenge backout during reverseForwardedObject(), but the fixup would depend on the related resverseForwardedPointer installed, so the scan for fix-up need to be done after all resverseForwardedPointer are installed, otherwise some fix-up would miss. Using backoutContinuationObjects() to scan/fixup all of continuation stack references in evacuate region. Signed-off-by: hulin <[email protected]>
LinHu2016
added a commit
to LinHu2016/openj9
that referenced
this pull request
May 27, 2024
In eclipse-openj9#19388, we are fixing up stack references of unmounted continuation for scavenge backout during reverseForwardedObject(), but the fixup would depend on the related resverseForwardedPointer installed, so the scan for fix-up need to be done after all resverseForwardedPointer are installed, otherwise some fix-up would miss. Using backoutContinuationObjects() to scan/fixup all of continuation stack references in evacuate region. Signed-off-by: hulin <[email protected]>
LinHu2016
added a commit
to LinHu2016/openj9
that referenced
this pull request
May 28, 2024
In eclipse-openj9#19388, we are fixing up stack references of unmounted continuation for scavenge backout during reverseForwardedObject(), but the fixup would depend on the related resverseForwardedPointer installed, so the scan for fix-up need to be done after all resverseForwardedPointer are installed, otherwise some fix-up would miss. Using backoutContinuationObjects() to scan/fixup all of continuation stack references in evacuate region. Signed-off-by: hulin <[email protected]>
LinHu2016
added a commit
to LinHu2016/openj9
that referenced
this pull request
May 29, 2024
In eclipse-openj9#19388, we are fixing up stack references of unmounted continuation for scavenge backout during reverseForwardedObject(), but the fixup would depend on the related resverseForwardedPointer installed, so the scan for fix-up need to be done after all resverseForwardedPointer are installed, otherwise some fix-up would miss. Using backoutContinuationObjects() to scan/fixup all of continuation stack references in evacuate region. Signed-off-by: hulin <[email protected]>
AswathySK
pushed a commit
to AswathySK/openj9
that referenced
this pull request
Jun 4, 2024
In eclipse-openj9#19388, we are fixing up stack references of unmounted continuation for scavenge backout during reverseForwardedObject(), but the fixup would depend on the related resverseForwardedPointer installed, so the scan for fix-up need to be done after all resverseForwardedPointer are installed, otherwise some fix-up would miss. Using backoutContinuationObjects() to scan/fixup all of continuation stack references in evacuate region. Signed-off-by: hulin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to no completeScan for scavenge backout(there are no need to fixup the references for regular objects in evacurated regions), the native stack references of unmounted continuation Objects might still point to the reversedForwardedObject in survior or tenure regions, it would cause the Assertion in following global GC.
update.
Port of #19341