Pass NULL as threadObject to walkContinuationStackFrames in GC #19487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GC Thread scanContinuationNativeSlots via walkContinuationStackFrames(), new threadObject parameter is required for calling walkContinuationStackFrames, retrieving the virtual thread Object during GC might trigger a read barrier in concurrent scavenger mode, because threadObject is not neccessary for GC case, so pass NULL as threadObject for call function walkContinuationStackFrames() to aviod the potential assertion. Signed-off-by: hulin <[email protected]>
dmitripivkine
added this to the
Release 0.46 (Java 8, 11, 17, 21, 22) July refresh milestone
|
While this is primarily meant to fix a problem with GC scanning, I believe passing null as VT thread object is also ok with other GC users, specifically a couple of 'walkers', like ReferenceChainWalker. |
amicic
approved these changes
May 13, 2024
|
jenkins test sanity aix,win jdk21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GC Thread scanContinuationNativeSlots via walkContinuationStackFrames(), new threadObject parameter is required for calling walkContinuationStackFrames, retrieving the virtual thread Object during GC might trigger a read barrier in concurrent scavenger mode, because threadObject is not neccessary for GC case, so pass NULL as threadObject for call function walkContinuationStackFrames() to aviod the potential assertion.
fix: #19486
Signed-off-by: hulin [email protected]