Skip to content

(0.46) Enabled AOT cache at server by default #19619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cjjdespres
Copy link
Contributor

This change makes the option -XX:+JITServerUseAOTCache unnecessary at the server; note that clients are still required to set that option to opt-in to the use of the AOT cache. The -XX:-JITServerUseAOTCache option may still be used at the server to disable the AOT cache as before.

This change also has the effect of making ROM class sharing at the server the default.

This change makes the option -XX:+JITServerUseAOTCache unnecessary at
the server; note that clients are still required to set that option to
opt-in to the use of the AOT cache. The -XX:-JITServerUseAOTCache option
may still be used at the server to disable the AOT cache as before.

This change also has the effect of making ROM class sharing at the
server the default.

Signed-off-by: Christian Despres <[email protected]>
@cjjdespres cjjdespres requested a review from dsouzai as a code owner June 4, 2024 15:40
@cjjdespres
Copy link
Contributor Author

Attn @mpirvu. This is a cherry-pick of commit 5af2b6e from PR #19584.

Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This PR only affects JITServer code. It's more of an usability issue, since the AOT cache needs to be enabled at the client too in order for the server to allocate any AOT cache related data structures.

@mpirvu mpirvu self-assigned this Jun 4, 2024
@mpirvu mpirvu added the comp:jitserver Artifacts related to JIT-as-a-Service project label Jun 4, 2024
@mpirvu mpirvu merged commit 8dfa90b into eclipse-openj9:v0.46.0-release Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:jitserver Artifacts related to JIT-as-a-Service project
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants