[0.46.0] Mark unlikely blocks as cold for Unsafe.{get|put}* #19681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In generating inline IL for Unsafe.get* and Unsafe.put* methods in the case where no conversion is needed, the blocks that test whether the object reference is null or whether the object's type is java/lang/Class had their frequencies set to VERSIONED_COLD_BLOCK_COUNT, copied from the indirect access block. However, unlike the indirect access block, those two blocks were not marked explicitly as cold. This change corrects that. Signed-off-by: Henry Zongaro <[email protected]>
hzongaro
changed the title
|
@vijaysun-omr, may I ask you to consider this for the 0.46.0 release? |
|
Very small change, and checks have passed on the head stream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In generating inline IL for
Unsafe.get*andUnsafe.put*methods in the case where no conversion is needed, the blocks that test whether the object reference is null or whether the object's type isjava/lang/Classhad their frequencies set toVERSIONED_COLD_BLOCK_COUNT, copied from the indirect access block. However, unlike the indirect access block, those two blocks were not marked explicitly as cold. This change corrects that.This is a port of pull request #19676 to the v0.46.0-release branch.