Skip to content

JFR Writer part 2 #19741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2024
Merged

JFR Writer part 2 #19741

merged 1 commit into from
Jul 9, 2024

Conversation

tajila
Copy link
Contributor

@tajila tajila commented Jun 21, 2024

  • modify iterateStackTraceImpl to take array instead of exception object as a walkback
  • add buffer writer API
  • add JFRChunkWriter API
  • add JFR ConstantPool types for type dictionary
  • add execution sample JAva native for testing purposes

@tajila tajila requested a review from gacholio June 21, 2024 16:33
@tajila
Copy link
Contributor Author

tajila commented Jun 21, 2024

@gacholio Please review these changes

@tajila tajila marked this pull request as draft June 21, 2024 16:33
@tajila tajila force-pushed the jfr branch 3 times, most recently from a50811b to f9410e8 Compare June 24, 2024 14:27
@gacholio
Copy link
Contributor

gacholio commented Jul 3, 2024

This all looks good to me.

@gacholio
Copy link
Contributor

gacholio commented Jul 4, 2024

Let me know when when you are done touching it up (mark as not draft).

@tajila tajila marked this pull request as ready for review July 4, 2024 12:09
@gacholio
Copy link
Contributor

gacholio commented Jul 4, 2024

One last thing - for the internal builds, you will need to either ifdef the files or add UMA excludes for them.

@tajila tajila force-pushed the jfr branch 3 times, most recently from 38d7cd7 to 08f47ec Compare July 4, 2024 19:55
@tajila
Copy link
Contributor Author

tajila commented Jul 4, 2024

I've added the ifdefs

@gacholio
Copy link
Contributor

gacholio commented Jul 5, 2024

I've added the ifdefs

Some of the files include JFR-specific headers - I suspect those includes will need to be inside the ifdefs.

@tajila
Copy link
Contributor Author

tajila commented Jul 5, 2024

jenkins test xlinux jdk8,jdk21

@tajila
Copy link
Contributor Author

tajila commented Jul 5, 2024

jenkins test sanity win jdk8,jdk21

@tajila
Copy link
Contributor Author

tajila commented Jul 5, 2024

jenkins test sanity xlinux jdk8,jdk21

@gacholio
Copy link
Contributor

gacholio commented Jul 5, 2024

The test native and internalVMFunctions field need to be ifdeffed (for simplicty just ifdef the contents of the native rather than removing it entirely).

@gacholio
Copy link
Contributor

gacholio commented Jul 5, 2024

Since this is test code, it might be better to move the executionSample code into the native then there would be need for the function table change.

@tajila
Copy link
Contributor Author

tajila commented Jul 7, 2024

Since this is test code, it might be better to move the executionSample code into the native then there would be need for the function table change.

If we do that jfrExecutionSample will need to go into the function table instead. I think ill remove it since you are working on the thread sampling.

@tajila tajila force-pushed the jfr branch 6 times, most recently from 6907f6b to 8d8eb39 Compare July 8, 2024 13:19
@gacholio
Copy link
Contributor

gacholio commented Jul 8, 2024

runtime/vm/JFRConstantPoolTypes.hpp:808: new blank line at EOF.

@tajila tajila force-pushed the jfr branch 10 times, most recently from d82fee3 to 4dfc683 Compare July 8, 2024 14:10
@tajila
Copy link
Contributor Author

tajila commented Jul 8, 2024

jenkins test sanity win jdk8,jdk21

@tajila
Copy link
Contributor Author

tajila commented Jul 8, 2024

jenkins test sanity xlinux jdk8,jdk21

@tajila
Copy link
Contributor Author

tajila commented Jul 9, 2024

jenkins test sanity xlinux jdk21

@tajila
Copy link
Contributor Author

tajila commented Jul 9, 2024

jenkins test sanity xlinux jdk8

@tajila
Copy link
Contributor Author

tajila commented Jul 9, 2024

jenkins test sanity win jdk8,jdk21

- modify iterateStackTraceImpl to take array instead of exception object
	as a walkback
- add buffer writer API
- add JFRChunkWriter API
- add JFR ConstantPool types for type dictionary
- add execution sample JAva native for testing purposes

Signed-off-by: tajila <[email protected]>
@tajila
Copy link
Contributor Author

tajila commented Jul 9, 2024

jenkins test sanity xlinux jdk8,jdk17,jdk21

@gacholio
Copy link
Contributor

gacholio commented Jul 9, 2024

This has passed compilation in an internal build.

@tajila
Copy link
Contributor Author

tajila commented Jul 9, 2024

Only failure was jitserver related.

@gacholio gacholio merged commit 4aa1e64 into eclipse-openj9:master Jul 9, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants