-
Notifications
You must be signed in to change notification settings - Fork 767
JFR Writer part 2 #19741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JFR Writer part 2 #19741
Conversation
tajila
commented
Jun 21, 2024
- modify iterateStackTraceImpl to take array instead of exception object as a walkback
- add buffer writer API
- add JFRChunkWriter API
- add JFR ConstantPool types for type dictionary
- add execution sample JAva native for testing purposes
@gacholio Please review these changes |
a50811b
to
f9410e8
Compare
This all looks good to me. |
Let me know when when you are done touching it up (mark as not draft). |
One last thing - for the internal builds, you will need to either ifdef the files or add UMA excludes for them. |
38d7cd7
to
08f47ec
Compare
I've added the ifdefs |
Some of the files include JFR-specific headers - I suspect those includes will need to be inside the ifdefs. |
jenkins test xlinux jdk8,jdk21 |
jenkins test sanity win jdk8,jdk21 |
jenkins test sanity xlinux jdk8,jdk21 |
The test native and internalVMFunctions field need to be ifdeffed (for simplicty just ifdef the contents of the native rather than removing it entirely). |
Since this is test code, it might be better to move the |
If we do that |
6907f6b
to
8d8eb39
Compare
|
d82fee3
to
4dfc683
Compare
jenkins test sanity win jdk8,jdk21 |
jenkins test sanity xlinux jdk8,jdk21 |
jenkins test sanity xlinux jdk21 |
jenkins test sanity xlinux jdk8 |
jenkins test sanity win jdk8,jdk21 |
- modify iterateStackTraceImpl to take array instead of exception object as a walkback - add buffer writer API - add JFRChunkWriter API - add JFR ConstantPool types for type dictionary - add execution sample JAva native for testing purposes Signed-off-by: tajila <[email protected]>
jenkins test sanity xlinux jdk8,jdk17,jdk21 |
This has passed compilation in an internal build. |
Only failure was jitserver related. |