Remove internal qtype methods #19752
Merged
+33
−279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theresa-m
requested review from
a7ehuo and
hangshao0
and removed request for
dsouzai
theresa-m
added
comp:vm
comp:test
project:valhalla
a7ehuo
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
The JIT change looks good to me. Thank you very much for making the update @theresa-m
@hzongaro fyi
hangshao0
reviewed
Jun 26, 2024
test/functional/Valhalla/src_qtypes/org/openj9/test/lworld/ValueTypeTests.java
Show resolved
Hide resolved
theresa-m
force-pushed
the
remove_q_5
branch
2 times, most recently
from
dc0b8e0 to
eb548aa
Compare
theresa-m
force-pushed
the
remove_q_5
branch
3 times, most recently
from
e38238b to
6cacde7
Compare
- isNameOrSignatureQType - isClassRefQtype - isFieldQType - isQDescriptorForValueTypesSupported Signed-off-by: Theresa Mammarella <[email protected]>
|
Jenkins test sanity,extended zlinuxval jdknext |
|
Jenkins test sanity,extended amac jdk21 |
hangshao0
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #18157