(0.46.0) Disable x86 TLH prefetch by default after Broadwell #19762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance analysis and measurement on multiple workloads suggests that enabling TLH prefetching by default on Skylake is suboptimal. Only enable by default up until the Broadwell microarchitecture. Signed-off-by: Daryl Maier <[email protected]>
|
This should be a safe change for 0.46. Performance runs have already been conducted on enterprise workloads. FYI @pshipton |
vijaysun-omr
approved these changes
Jun 26, 2024
|
I checked the change is the same as done in dev. It is a very safe change (only affects prefetch on skylake). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance analysis and measurement on multiple workloads suggests that enabling TLH prefetching by default on Skylake is suboptimal. Only enable by default up until the Broadwell microarchitecture.