Call getCpeTypeForProtocol only if URL is not cached #19769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshipton
reviewed
Jun 27, 2024
pshipton
reviewed
Jun 27, 2024
hangshao0
reviewed
Jun 28, 2024
|
@theresa-m There are merge conflicts. |
Signed-off-by: Theresa Mammarella <[email protected]>
|
Jenkins test sanity,extended win jdk8 |
|
Jenkins test sanity,extended amac jdk21 |
hangshao0
approved these changes
Jul 8, 2024
This was referenced Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously getCpeTypeForProtocol was being called regardless of whether the URL was cached causing extra calls to j9file_attr.
Related to #19380