Skip to content

Add new com.ibm.autocvt property for z/OS file tagging support #19772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

joransiu
Copy link
Member

As part of better handling of JEP400 constraints on z/OS, the com.ibm.autocvt property is added to control whether we convert input file I/O based on file tagging. If not explicitly specified, the property defaults to true, unless file.encoding is set to COMPAT.

@joransiu joransiu requested review from keithc-ca and pshipton June 27, 2024 18:26
@joransiu
Copy link
Member Author

@keithc-ca : Thanks, I've updated the PR with your suggested changes.

Here are the combinations and respective results:

$ java -XshowSettings:properties -version 2>&1 | grep autocvt
    com.ibm.autocvt = true
$ java -Dfile.encoding=COMPAT -XshowSettings:properties -version 2>&1 | grep autocvt
    com.ibm.autocvt = false
$ java -Dfile.encoding=IBM-1047 -XshowSettings:properties -version 2>&1 | grep autocvt
    com.ibm.autocvt = true
$ java -Dcom.ibm.autocvt=true -Dfile.encoding=COMPAT -XshowSettings:properties -version 2>&1 | grep autocvt
    com.ibm.autocvt = true
$ java -Dcom.ibm.autocvt=false -XshowSettings:properties -version 2>&1 | grep autocvt
    com.ibm.autocvt = false

@keithc-ca
Copy link
Contributor

Please fix the commit message: lines in the body should be no more than 72 characters long; see https://github.com/eclipse/omr/blob/master/CONTRIBUTING.md#commit-guidelines.

As part of better handling of JEP400 constraints on z/OS, the
com.ibm.autocvt property is added to control whether we convert input
file I/O based on file tagging. If not explicitly specified, the
property defaults to true, unless file.encoding is set to COMPAT.

Signed-off-by: Joran Siu <[email protected]>
@joransiu
Copy link
Member Author

Please fix the commit message: lines in the body should be no more than 72 characters long; see eclipse/omr@master/CONTRIBUTING.md#commit-guidelines.

Fixed commit message under: a1d86d1

@keithc-ca
Copy link
Contributor

Jenkins compile amac jdk23

@keithc-ca keithc-ca merged commit c05e25e into eclipse-openj9:master Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants