Use C++-style initialization for zeroed array type #19804
Conversation
The {} initializer will zero-initialize a variable of the array type
`jmp_buf`. Clang otherwise complains about the use of `0` to
zero-initialize this array type.
Signed-off-by: Christian Despres <[email protected]>
|
Attn @mpirvu. |
| @@ -55,7 +55,7 @@ ffiCallWithSetJmpForUpcall(J9VMThread *currentThread, ffi_cif *cif, void *functi | |||
| ffiCallWithSetJmpForUpcall(J9VMThread *currentThread, ffi_cif *cif, void *function, UDATA *returnStorage, void **values) | |||
| #endif /* FFI_NATIVE_RAW_API */ | |||
| { | |||
| jmp_buf jmpBufferEnv = {0}; | |||
| jmp_buf jmpBufferEnv = {}; | |||
There was a problem hiding this comment.
Reading the documentation I see that { } was introduced in C23: https://en.cppreference.com/w/c/language/array_initialization
There was a problem hiding this comment.
I cannot find when initializing an array with {} in c++ started to be valid.
There was a problem hiding this comment.
Perhaps we should omit = to use a form that has been valid since C++11?
jmp_buf jmpBufferEnv {};
There was a problem hiding this comment.
Whatever you decide on, pls try it in a vmfarm build on Linux PPC BE, AIX and z/OS before merging.
There was a problem hiding this comment.
I was going to suggest that until I noticed that this code is guarded by #if JAVA_SPEC_VERSION >= 16.
There was a problem hiding this comment.
I think the syntax I have is okay even before C++-11, judging from the articles initialization and aggregate_initialization - it's either aggregate initialization or list initialization of an aggregate type (an array type). I don't think the C standard applies here.
The page zero_initialization does point out that jmp_buf jmpBufferEnv {}; will work, as you say.
There was a problem hiding this comment.
I thought you agree with my suggestion (#19804 (comment)), but this was merged without that change being made. What happened?
|
@keithc-ca Since this is vm code, I would appreciate a review from you. Thanks |
|
jenkins compile all jdk8,jdk21 |
I interpreted this as being conforming c++ code and therefore it should compile on all platforms. It did compile successfully on all platforms that are tested externally. |
The
{}initializer will zero-initialize a variable of the array typejmp_buf. Clang otherwise complains about the use of0to zero-initialize this array type.