Use custom allocator for JITServer client MessageBuffers #19808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attn @mpirvu. I wasn't sure where to put it, so this happens to attempt to destroy the |
mpirvu
reviewed
Jul 4, 2024
cjjdespres
force-pushed
the
disclaim-free-message-buffer
branch
from
3938aeb to
234bade
Compare
mpirvu
reviewed
Jul 5, 2024
cjjdespres
force-pushed
the
disclaim-free-message-buffer
branch
from
234bade to
9c1fac9
Compare
|
jenkins test sanity xlinuxjit,zlinuxjit,alinux64jit jdk21 |
1 similar comment
|
jenkins test sanity xlinuxjit,zlinuxjit,alinux64jit jdk21 |
|
coredumps on x86 |
|
I tried AcmeAirEE8 with this change and the server is crashing. Something is not right. |
|
I see one thing wrong - when I moved the monitor initialization into |
A global, reference-counted allocator is now created at JITServer clients that is used to allocate the memory used by the internal MessageBuffer storage buffer during client/server communication. This allocator's memory segments are disclaimed if the number of connections to the server drops to zero, and the compiler will also periodically attempt to destroy the allocator entirely. Signed-off-by: Christian Despres <[email protected]>
cjjdespres
force-pushed
the
disclaim-free-message-buffer
branch
from
9c1fac9 to
5c98d28
Compare
|
That should be fixed. |
|
jenkins test sanity xlinuxjit,zlinuxjit,alinux64jit jdk21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A global, reference-counted allocator is now created at JITServer clients that is used to allocate the memory used by the internal MessageBuffer storage buffer during client/server communication. This allocator's memory segments are disclaimed if the number of connections to the server drops to zero, and the compiler will also periodically attempt to destroy the allocator entirely.