Remove extra newlines in generated assembly files #19879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r30shah
approved these changes
Jul 23, 2024
|
It was not verified yet. Still working on fully upstreaming all changes across my different branches, I seem to have missed a few files that I am finding out and cleaning up. |
|
I have launched a Java8 build internally for sanity : http://vmfarm.rtp.raleigh.ibm.com/build_info.php?build_id=75022 Launching sanity build here as well |
|
jenkins test sanity zlinux jdk21 |
keithc-ca
reviewed
Jul 23, 2024
keithc-ca
requested changes
Jul 24, 2024
keithc-ca
changed the title
Deigue
force-pushed
the
openxl-m4gen
branch
2 times, most recently
from
0972fd4 to
62b0a56
Compare
|
Thanks for the suggestions, I've modified according to feedback and seems to be good with compiling. |
keithc-ca
reviewed
Aug 2, 2024
Deigue
force-pushed
the
openxl-m4gen
branch
2 times, most recently
from
dfc71e8 to
b7db14a
Compare
|
Please update the commit message: the summary line should not end with a period. |
keithc-ca
changed the title
Similar to previously fixed Open XL errors, there were some more m4 files that generated extra newlines at the end of the generated assembly files. These changes make the tweaks to address this so as to only leave a single newline at the end of these generated assembly files. Signed-off-by: Gaurav Chaudhari <[email protected]>
keithc-ca
approved these changes
Aug 12, 2024
|
Jenkins compile zlinux jdk21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to previously fixed Open XL errors, there were some more m4 files that generated extra newlines at the end of the generated assembly files. These changes make the tweaks to address this so as to only leave a single newline at the end of these generated assembly files.