Add triggerExecutionSample native #19917

thallium · 2024-07-24T20:43:45Z

Add JPP flag for JFR
Add com.ibm.oti.vm.VM::triggerExecutionSample that calls jfrExecutionSample on all Java threads
Add test for triggerExecutionSample

thallium · 2024-07-24T20:49:47Z

@tajila Can you please take a look? I'm not quite familiar with adding tests so I'm expecting to miss something e.g. only enable the test when JFR is enabled.

tajila · 2024-07-25T01:50:20Z

Please name this PR something like "Add triggerExecutionSample native"

test/functional/cmdLineTests/jfr/playlist.xml

Related: eclipse-openj9/openj9#19917 Signed-off-by: Gengchen Tuo <[email protected]>

tajila · 2024-07-25T13:47:47Z

@JasonFengJ9 Please review these changes

Related: eclipse-openj9/openj9#19917 Signed-off-by: Gengchen Tuo <[email protected]>

jcl/src/java.base/share/classes/com/ibm/oti/vm/VM.java

runtime/jcl/common/com_ibm_oti_vm_VM.cpp

runtime/oti/jclprots.h

test/functional/cmdLineTests/jfr/playlist.xml

thallium · 2024-07-25T19:17:49Z

Addressed all the feedbacks above.

test/functional/cmdLineTests/jfr/playlist.xml

test/functional/cmdLineTests/jfr/build.xml

JasonFengJ9 · 2024-07-26T14:11:38Z

15:17:42 test/functional/cmdLineTests/jfr/metadata.blob:164: trailing whitespace.
15:17:42 +��S��

Is there a way to generate this file dynamically? otherwise, the line endings check needs to skip this type of file.

This will help JFR related tests in the future. Related: eclipse-openj9/openj9#19917 Signed-off-by: Gengchen Tuo <[email protected]>

tajila · 2024-07-26T14:46:16Z

15:17:42 test/functional/cmdLineTests/jfr/metadata.blob:164: trailing whitespace.
15:17:42 +��S����������

Is there a way to generate this file dynamically? otherwise, the line endings check needs to skip this type of file.

There is no way to do this currently. We need to skip file endings check for this file.

JasonFengJ9 · 2024-07-26T14:54:04Z

Opened an issue

Jenkins line endings check needs to skip metadata.blob files #19923

thallium · 2024-07-26T15:17:47Z

Opend PR in TKG:
adoptium/TKG#589

thallium · 2024-07-26T15:23:31Z

Updated PR.

Related: eclipse-openj9/openj9#19917 Signed-off-by: Gengchen Tuo <[email protected]>

JasonFengJ9 · 2024-07-29T12:52:12Z

Opend PR in TKG:
adoptium/TKG#589

Merged

JasonFengJ9

LGTM

tajila · 2024-07-29T13:02:25Z

jenkins test sanity xlinux jdk17

runtime/jcl/common/com_ibm_oti_vm_VM.cpp

runtime/jcl/exports.cmake

test/functional/cmdLineTests/jfr/build.xml

test/functional/cmdLineTests/jfr/jfr.xml

keithc-ca · 2024-07-29T17:27:59Z

.gitattributes should be updated to identify *.blob as binary files.

thallium · 2024-07-29T17:44:49Z

@keithc-ca all your feedbacks have been addressed. Also can we get ibmruntimes/openj9-openjdk-jdk#817 merged?

.gitattributes

runtime/jcl/exports.cmake

test/functional/cmdLineTests/jfr/build.xml

test/functional/cmdLineTests/jfr/playlist.xml

keithc-ca · 2024-07-29T21:06:50Z

The commit message says this "Depend on" ibmruntimes/openj9-openjdk-jdk#817; the dependency is in the other direction. Please correct that.

- Add JPP flag for JFR - Add com.ibm.oti.vm.VM::triggerExecutionSample that calls jfrExecutionSample on all Java threads - Add test for triggerExecutionSample Related: - ibmruntimes/openj9-openjdk-jdk#817 Depend on: - adoptium/TKG#589 Signed-off-by: Gengchen Tuo <[email protected]>

tajila · 2024-07-30T14:39:19Z

@keithc-ca Any further comments?

test/functional/cmdLineTests/jfr/playlist.xml

keithc-ca · 2024-07-30T17:21:59Z

I believe the previous PR build (https://openj9-jenkins.osuosl.org/job/Build_JDK17_x86-64_linux_Personal/907) is still valid.

Depend on: eclipse-openj9/openj9#19917 Related: ibmruntimes/openj9-openjdk-jdk#817 Signed-off-by: Gengchen Tuo <[email protected]>

tajila requested a review from JasonFengJ9 July 25, 2024 01:31

tajila reviewed Jul 25, 2024

View reviewed changes

test/functional/cmdLineTests/jfr/playlist.xml Show resolved Hide resolved

thallium force-pushed the jfr-cpp-flag branch from ca07693 to bc1a949 Compare July 25, 2024 13:16

thallium changed the title ~~JFR Work~~ Add triggerExecutionSample native Jul 25, 2024

thallium added a commit to thallium/openj9-openjdk-jdk21 that referenced this pull request Jul 25, 2024

Add JFR JPP flag

416c52e

Related: eclipse-openj9/openj9#19917 Signed-off-by: Gengchen Tuo <[email protected]>

thallium mentioned this pull request Jul 25, 2024

Add JFR JPP flag ibmruntimes/openj9-openjdk-jdk21#177

Merged

thallium force-pushed the jfr-cpp-flag branch from bc1a949 to 4fd4965 Compare July 25, 2024 13:48

thallium added a commit to thallium/openj9-openjdk-jdk that referenced this pull request Jul 25, 2024

Add JFR JPP flag

83053a4

Related: eclipse-openj9/openj9#19917 Signed-off-by: Gengchen Tuo <[email protected]>

thallium mentioned this pull request Jul 25, 2024

Add JFR JPP flag ibmruntimes/openj9-openjdk-jdk#817

Merged

thallium added a commit to thallium/openj9-openjdk-jdk that referenced this pull request Jul 25, 2024

Add JFR JPP flag

6336dd2

Related: eclipse-openj9/openj9#19917 Signed-off-by: Gengchen Tuo <[email protected]>

thallium added a commit to thallium/openj9-openjdk-jdk21 that referenced this pull request Jul 25, 2024

Add JFR JPP flag

0de6e8b

Related: eclipse-openj9/openj9#19917 Signed-off-by: Gengchen Tuo <[email protected]>

JasonFengJ9 reviewed Jul 25, 2024

View reviewed changes

jcl/src/java.base/share/classes/com/ibm/oti/vm/VM.java Show resolved Hide resolved

runtime/jcl/common/com_ibm_oti_vm_VM.cpp Show resolved Hide resolved

runtime/oti/jclprots.h Outdated Show resolved Hide resolved

test/functional/cmdLineTests/jfr/playlist.xml Show resolved Hide resolved

thallium force-pushed the jfr-cpp-flag branch from 4fd4965 to 5a09023 Compare July 25, 2024 19:15

JasonFengJ9 reviewed Jul 25, 2024

View reviewed changes

test/functional/cmdLineTests/jfr/playlist.xml Outdated Show resolved Hide resolved

test/functional/cmdLineTests/jfr/build.xml Outdated Show resolved Hide resolved

thallium added a commit to thallium/TKG that referenced this pull request Jul 26, 2024

Add JFR check to test flags

18d0c67

This will help JFR related tests in the future. Related: eclipse-openj9/openj9#19917 Signed-off-by: Gengchen Tuo <[email protected]>

JasonFengJ9 mentioned this pull request Jul 26, 2024

Jenkins line endings check needs to skip metadata.blob files #19923

Closed

thallium mentioned this pull request Jul 26, 2024

Add JFR check to test flags adoptium/TKG#589

Merged

thallium force-pushed the jfr-cpp-flag branch from 5a09023 to 2ab00b3 Compare July 26, 2024 15:20

JasonFengJ9 pushed a commit to JasonFengJ9/openj9-openjdk-jdk that referenced this pull request Jul 28, 2024

Add JFR JPP flag

be2983d

Related: eclipse-openj9/openj9#19917 Signed-off-by: Gengchen Tuo <[email protected]>

JasonFengJ9 approved these changes Jul 29, 2024

View reviewed changes

JasonFengJ9 added the comp:vm label Jul 29, 2024

keithc-ca requested changes Jul 29, 2024

View reviewed changes

thallium force-pushed the jfr-cpp-flag branch from 2ab00b3 to f65b93b Compare July 29, 2024 17:32

keithc-ca requested changes Jul 29, 2024

View reviewed changes

.gitattributes Outdated Show resolved Hide resolved

runtime/jcl/exports.cmake Outdated Show resolved Hide resolved

test/functional/cmdLineTests/jfr/build.xml Outdated Show resolved Hide resolved

test/functional/cmdLineTests/jfr/playlist.xml Outdated Show resolved Hide resolved

thallium force-pushed the jfr-cpp-flag branch from f65b93b to a259f6d Compare July 29, 2024 20:20

thallium force-pushed the jfr-cpp-flag branch from a259f6d to 3f48ea9 Compare July 30, 2024 01:31

keithc-ca reviewed Jul 30, 2024

View reviewed changes

test/functional/cmdLineTests/jfr/playlist.xml Show resolved Hide resolved

keithc-ca approved these changes Jul 30, 2024

View reviewed changes

keithc-ca merged commit a3a0974 into eclipse-openj9:master Jul 30, 2024
2 checks passed

thallium added a commit to thallium/openj9-openjdk-jdk23 that referenced this pull request Jul 30, 2024

Add JFR JPP flag

1fe9c11

Depend on: eclipse-openj9/openj9#19917 Related: ibmruntimes/openj9-openjdk-jdk#817 Signed-off-by: Gengchen Tuo <[email protected]>

thallium added a commit to thallium/openj9-openjdk-jdk22 that referenced this pull request Jul 30, 2024

Add JFR JPP flag

fc41bc5

Depend on: eclipse-openj9/openj9#19917 Related: ibmruntimes/openj9-openjdk-jdk#817 Signed-off-by: Gengchen Tuo <[email protected]>

This was referenced Jul 30, 2024

Add JFR JPP flag ibmruntimes/openj9-openjdk-jdk23#23

Merged

Add JFR JPP flag ibmruntimes/openj9-openjdk-jdk22#88

Merged

Add triggerExecutionSample native #19917

Add triggerExecutionSample native #19917

Conversation

thallium commented Jul 24, 2024

Uh oh!

thallium commented Jul 24, 2024

Uh oh!

tajila commented Jul 25, 2024

Uh oh!

Uh oh!

tajila commented Jul 25, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thallium commented Jul 25, 2024

Uh oh!

Uh oh!

Uh oh!

JasonFengJ9 commented Jul 26, 2024

Uh oh!

tajila commented Jul 26, 2024

Uh oh!

JasonFengJ9 commented Jul 26, 2024

Uh oh!

thallium commented Jul 26, 2024

Uh oh!

thallium commented Jul 26, 2024

Uh oh!

JasonFengJ9 commented Jul 29, 2024

Uh oh!

JasonFengJ9 left a comment

Choose a reason for hiding this comment

Uh oh!

tajila commented Jul 29, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

keithc-ca commented Jul 29, 2024

Uh oh!

thallium commented Jul 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

keithc-ca commented Jul 29, 2024

Uh oh!

tajila commented Jul 30, 2024

Uh oh!

Uh oh!

keithc-ca commented Jul 30, 2024

Uh oh!

Uh oh!

Uh oh!

thallium commented Jul 29, 2024 •

edited

Loading